Add a skip to an empty test group
#5080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The empty group will soon become a warning or an error. Eagerly skip the group to avoid any issue when the test runner changes behavior. dart-lang/test#2012 Note that the linked issue has been resolved, and the comment in this group body may be out of date. This change will impact the output from running tests - there will be an indication of the skipped test.
domesticmouse
approved these changes
Oct 8, 2023
domesticmouse
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 9, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 9, 2023
flutter/packages@e578a16...7de08ec 2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.9 to 2.22.0 (flutter/packages#5092) 2023-10-09 [email protected] Add a `skip` to an empty test group (flutter/packages#5080) 2023-10-07 [email protected] Roll Flutter from ad20089 to 5207a30 (20 revisions) (flutter/packages#5086) 2023-10-06 [email protected] Roll Flutter from fe0275f to ad20089 (10 revisions) (flutter/packages#5084) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@e578a16...7de08ec 2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.9 to 2.22.0 (flutter/packages#5092) 2023-10-09 [email protected] Add a `skip` to an empty test group (flutter/packages#5080) 2023-10-07 [email protected] Roll Flutter from ad20089 to 5207a30 (20 revisions) (flutter/packages#5086) 2023-10-06 [email protected] Roll Flutter from fe0275f to ad20089 (10 revisions) (flutter/packages#5084) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The empty group will soon become a warning or an error. Eagerly skip the
group to avoid any issue when the test runner changes behavior.
dart-lang/test#2012
Note that the linked issue has been resolved, and the comment in this
group body may be out of date.
This change will impact the output from running tests - there will be an
indication of the skipped test.